Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Job Launcher] Add signature to all webhook calls #1050

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

flopez7
Copy link
Contributor

@flopez7 flopez7 commented Oct 13, 2023

Description

Add signature to all webhook endpoints in Job Launcher

Summary of changes

  • Improve signature guard
  • Add signature verification to all webhook endpoints
  • Format code

How test the changes

yarn test

Related issues

Close #1027 #999

Operational checklist

  • All new functionality is covered by tests
  • Any related documentation has been changed or added

@flopez7 flopez7 requested a review from portuu3 October 13, 2023 12:39
@flopez7 flopez7 self-assigned this Oct 13, 2023
@vercel
Copy link

vercel bot commented Oct 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
job-launcher-server ✅ Ready (Inspect) Visit Preview Oct 13, 2023 0:39am
10 Ignored Deployments
Name Status Preview Updated (UTC)
escrow-dashboard ⬜️ Ignored (Inspect) Oct 13, 2023 0:39am
faucet-server ⬜️ Ignored (Inspect) Oct 13, 2023 0:39am
fortune-exchange-oracle ⬜️ Ignored (Inspect) Oct 13, 2023 0:39am
fortune-exchange-oracle-server ⬜️ Ignored (Inspect) Oct 13, 2023 0:39am
fortune-job-launcher-client ⬜️ Ignored (Inspect) Oct 13, 2023 0:39am
fortune-job-launcher-server ⬜️ Ignored (Inspect) Oct 13, 2023 0:39am
fortune-recording-oracle ⬜️ Ignored (Inspect) Oct 13, 2023 0:39am
fortune-reputation-oracle ⬜️ Ignored (Inspect) Oct 13, 2023 0:39am
human-protocol-typescript-sdk-docs ⬜️ Ignored (Inspect) Oct 13, 2023 0:39am
job-launcher-client ⬜️ Ignored (Inspect) Oct 13, 2023 0:39am

@flopez7 flopez7 merged commit e45d28f into develop Oct 17, 2023
@flopez7 flopez7 deleted the feat/job-launcher/webhook-signature branch October 17, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants