[SDK][Agreement] Fix value range for measures. #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add warnings for degenerate cases.
simulacrum6
added
bug
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
vercel
bot
temporarily deployed
to
Preview – human-protocol-typescript-sdk-docs
flopez7
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the value range for
fleiss_kappa,cohens_kappaandpercentageto stay within, even in edge cases.Summary of changes
np.nananymore, when all annotations have the same label or annotation data contains only a single annotator. Instead 1.0 is returned and a warning is raised. This is done to ensure measures will be more robust to degenerate cases yet still inform the users about potential problems in their data. This also helps with bootstrapping, as the confidence intervals cannot benananymore.How test the changes
pytest PYTHON_SDK_DIR/test/agreement
Related issues
Operational checklist