Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK - Urls from kvstore #1604

Closed
portuu3 opened this issue Feb 19, 2024 · 0 comments
Closed

SDK - Urls from kvstore #1604

portuu3 opened this issue Feb 19, 2024 · 0 comments
Assignees
@leric7
Labels
SDK

Comments

@portuu3
Copy link
Collaborator

portuu3 commented Feb 19, 2024

Description
This should be done in both TS and Python Sdks:

  • Rename getUrl function from KVStore module to be more descriptive (Suggestion: getFileUrlAndVerifyHash)
  • Rename setUrl function from KVStore module to be more descriptive (Suggestion: setFileUrlAndHash)
  • Add a new function to specifically the public key: getPublicKey. It should pull the file, verify the hash and return the public key value.

Motivation
Improve SDK usability
@portuu3 portuu3 added the SDK label Feb 19, 2024
@portuu3 portuu3 moved this to Backlog in Core-tech - 2024 Feb 19, 2024
@portuu3 portuu3 mentioned this issue Feb 20, 2024
Closed
@portuu3 portuu3 moved this from Backlog to Todo in Core-tech - 2024 Feb 20, 2024
@leric7 leric7 moved this from Todo to In Progress in Core-tech - 2024 Feb 27, 2024
@leric7 leric7 mentioned this issue Feb 27, 2024
Merged
@leric7 leric7 moved this from In Progress to In Review in Core-tech - 2024 Feb 27, 2024
portuu3 pushed a commit that referenced this issue Mar 5, 2024
@leric7
[SDK] feat: update KVStoreClient [#1604] (#1640)
40549ad 
* feat: update KVStoreClient SDK

* fix get public key

* [SDK] feat: Use snake case for KVStore keys [#1605] (#1659)

* use snake case for kvstore keys

* update doc

* fix subgraph backward compatibility
@leric7 leric7 closed this as completed Mar 5, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Core-tech - 2024 Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leric7 leric7

Labels
SDK
Projects
Core-tech - 2024
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@portuu3 @leric7