Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use pod identity #14

Merged

Conversation

johanneswuerbach
Copy link
Contributor

Enable the EKS Pod Identity Addon and upgrade to the terraform-aws-modules/eks/aws v20.

@johanneswuerbach johanneswuerbach requested a review from a team as a code owner February 6, 2024 22:09
Copy link

@mateuszjenek mateuszjenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general

@@ -48,11 +48,6 @@ data "aws_caller_identity" "current" {}

locals {
default_aws_auth_users = [
{
Copy link

@mateuszjenek mateuszjenek Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing this user?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is handled by the enable_cluster_creator_admin_permissions = true, which also creates an admin for the current user.

@johanneswuerbach johanneswuerbach merged commit 05e9d66 into humanitec-architecture:main Feb 8, 2024
1 check passed
@johanneswuerbach johanneswuerbach deleted the pod-identity branch February 8, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants