Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce import time part 2: lazy import rarely used datetime #250

Closed
wants to merge 4 commits into from

Conversation

hukkin
Copy link
Owner

@hukkin hukkin commented Jan 9, 2025

No description provided.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1da01ef) to head (9f5f40e).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #250   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          526       528    +2     
  Branches        97        97           
=========================================
+ Hits           526       528    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hukkin
Copy link
Owner Author

hukkin commented Jan 14, 2025

import datetime is very fast in Python 3.12+ (see python/cpython#84976) so I'm thinking this isn't necessary.

@hukkin hukkin closed this Jan 14, 2025
@hukkin hukkin deleted the importtime-pt2 branch January 14, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant