Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If removal version has arrived, raise an error #84

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

radarhere
Copy link

An idea for python-pillow#6184. Feel free to disregard if you want, as it is rather theoretical.

What if we managed to accidentally leave in a Pillow 10 deprecation warning for the Pillow 10 release?
Users would then be told that the feature would be removed in Pillow 10, with a date in the past, which would introduce confusion.
Or worse, we might have removed the when == 10 condition, and they would receive a ValueError.
Instead, we could switch to the generic statement that it would be removed in "a future version".

@radarhere radarhere force-pushed the deprecations-helper branch from 6ce1ebe to 1fd8d90 Compare April 8, 2022 10:42
@hugovk
Copy link
Owner

hugovk commented Apr 8, 2022

What if we managed to accidentally leave in a Pillow 10 deprecation warning for the Pillow 10 release?

Or to address this more directly, we could raise an error if there's a Pillow 10 deprecation still in Pillow 10, and we'll see it during the 3-month dev period.

This idea comes from the internal warnings._deprecated() function recently added to CPython:

@radarhere radarhere force-pushed the deprecations-helper branch from 1fd8d90 to e824558 Compare April 8, 2022 11:23
@radarhere radarhere changed the title If removal version has arrived, do not show past date If removal version has arrived, raise an error Apr 8, 2022
@hugovk hugovk merged commit 3315959 into hugovk:deprecations-helper Apr 8, 2022
@hugovk
Copy link
Owner

hugovk commented Apr 8, 2022

Thank you!

@radarhere radarhere deleted the deprecations-helper branch April 15, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants