fix: fix maximum call stack size with fallback sort

hugop95 · Feb 17, 2025 · 8b78710 · 8b78710
1 parent a38fc8c
commit 8b78710
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/test/utils/compare.test.ts b/test/utils/compare.test.ts
@@ -330,6 +330,20 @@ describe('compare', () => {
         }),
       ).toBe(-1)
     })
+
+    it("doesn't sort using the fallback configuration more than once", () => {
+      let node = createTestNode({ name: 'aaa' })
+      let duplicateNode = createTestNode({ name: 'aaa' })
+      expect(
+        compare(node, duplicateNode, {
+          ...compareOptions,
+          fallbackSort: {
+            type: 'alphabetical',
+            order: 'asc',
+          } as const,
+        }),
+      ).toBe(0)
+    })
   })
 
   let createTestNode = ({ name }: { name: string }): SortingNode =>

diff --git a/utils/compare.ts b/utils/compare.ts
@@ -101,9 +101,11 @@ export let compare = <T extends SortingNode>(
   let { fallbackSort, order } = options
   return compare(a, b, {
     ...options,
+    fallbackSort: {
+      type: 'unsorted',
+    },
     order: fallbackSort.order ?? order,
     type: fallbackSort.type,
-    fallbackSort,
   } as CompareOptions<T>)
 }