Skip to content

Commit

Permalink
Fix ubuntu aarch64 build (#152)
Browse files Browse the repository at this point in the history
Build on ubuntu-22.04, aarch64 has been failing since [this
commit](8f52fad),
looks like jsonwebtoken introduced ring and the ARM assembler doesn't
like it:
[CI](https://github.com/huggingface/xet-core/actions/runs/12895273205/job/35955801283#step:4:812).
A
[comment](briansmith/ring#1728 (comment))
under a ring repo related issue mentioned that
"[manylinux_2_28](https://github.com/rust-cross/manylinux-cross#manylinux_2_28)
based on GCC 7.5.0 works fine".
  • Loading branch information
seanses authored Jan 24, 2025
1 parent bbcf196 commit ebb9ff5
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,11 @@ jobs:
platform:
- runner: ubuntu-22.04
target: x86_64
manylinux: auto
features: "--features openssl_vendored"
- runner: ubuntu-22.04
target: aarch64
manylinux: manylinux_2_28
features: "--features openssl_vendored"
steps:
- uses: actions/checkout@v4
Expand All @@ -42,7 +44,7 @@ jobs:
target: ${{ matrix.platform.target }}
args: --release ${{ matrix.platform.features }} --out dist
sccache: 'true'
manylinux: auto
manylinux: ${{ matrix.platform.manylinux }}
working-directory: hf_xet
before-script-linux: |
if command -v apt-get &> /dev/null; then
Expand Down

0 comments on commit ebb9ff5

Please sign in to comment.