make distributed true for multiple process #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distributed should have more than 1 process Co-authored-by: Younes Belkada <[email protected]>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
It's kind of my first time to make PR here. So I guess one more review needed? @younesbelkada |
|
No this is great! Merging! |
younesbelkada
approved these changes
Nov 15, 2023
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
* make distributed true for multiple process * Update trl/trainer/ppo_trainer.py distributed should have more than 1 process Co-authored-by: Younes Belkada <[email protected]> --------- Co-authored-by: Younes Belkada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the issue in #960 (comment)
The issue will cause "gather stat" not to work for other distributed scenarios other than
MULTI_GPU.