-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert notebook 05 #80
Conversation
0cbeb81
to
320826c
Compare
The documentation is not available anymore as the PR was closed or merged. |
Hi @edbeeching, thanks for updating the notebook! Looks really good, here a few points:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good to me! Thanks for working on this !
There are still some issues regarding loss spikes (see #101). Will merge for now and investigate further. @natolambert you can use this notebook to see investigate the spikes. Full logs of a run can be found here. |
@lvwerra and @younesbelkada , thanks for looking at, fixing and merging this. I have gone a bit silent due to pat leave, looking forward to getting back to work :) |
I am going to make another PR where this notebook is in example form -- much easier for doing multiple jobs and wider scale experimentation. It's also interesting that @edbeeching 's example didn't have the reward spike. I keep finding things to play with, so that's good for now. |
This PR converts notebook 5, gpt2 sentiment control to work with new API.
I benchmarked for 2 hours - 200 iterations, the wandb report is here, here is the original one for comparison. (currently private, owned by @lvwerra )
Resolves issues #71 and #79