[VHead] Fix slow convergence issue
#60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a behaviour that we have encountered with #53 - for some reason the aforementioned PR lead to having models that does behave exactly similarly as the reference model, for the policy metrics, more precisely the
kl,policyklapproxklwere much more different than before.The issue seemed to be related to the initialization strategy of the VHead model. In #53
_init_weightsmethod was introduced for consistency withtransformersand to give users the possibility to tweak the initialization strategy of the VHead module.This PR fixes the behaviour precised above, by randomly initilazing the weights by default
cc @lvwerra