Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SFT] fix check for AutoLigerKernelForCausalLM #2874

Merged
merged 5 commits into from
Feb 17, 2025
Merged

[SFT] fix check for AutoLigerKernelForCausalLM #2874

merged 5 commits into from
Feb 17, 2025

Conversation

kashif
Copy link
Collaborator

@kashif kashif commented Feb 16, 2025

What does this PR do?

Covers the edge case when an AutoLigerKernelForCausalLM is passed to the SFTTrainer and use_liger is the default

fixes linkedin/Liger-Kernel#568

@kashif kashif requested a review from qgallouedec February 16, 2025 08:06
@kashif
Copy link
Collaborator Author

kashif commented Feb 16, 2025

cc @eliebak

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@kashif kashif merged commit 6d9fc11 into main Feb 17, 2025
14 checks passed
@kashif kashif deleted the fix-liger-sft branch February 17, 2025 06:50
qgallouedec pushed a commit that referenced this pull request Feb 17, 2025
* fix check for AutoLigerKernelForCausalLM

* fix case where AutoLigerKernelForCausalLM is not defined

* update min liger version

* formatting

* fix win CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: 'NoneType' object is not subscriptable. With trl==0.15.0 and later.
3 participants