💬 Add maybe_convert_to_chatml map for conversational datasets in SFT
#2862
+150
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
5 tasks
kashif
changed the title
qgallouedec
approved these changes
Feb 17, 2025
qgallouedec
reviewed
Feb 17, 2025
qgallouedec
changed the title
maybe_convert_to_chatml map for conversational datasets and fix SFT support
qgallouedec
changed the title
maybe_convert_to_chatml map for conversational datasets and fix SFT supportmaybe_convert_to_chatml map for conversational datasets in SFT
qgallouedec
added a commit
that referenced
this pull request
Feb 17, 2025
#2862) * add back get_formatting_func_from_dataset * maybe_convert_to_chatml * maybe_convert_to_chatml before maybe_apply_chat_template map * remove comment * test * desc * style * Update trl/data_utils.py --------- Co-authored-by: Quentin Gallouédec <[email protected]> Co-authored-by: Quentin Gallouédec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes the issue when the messages have other keys than "role" and "content"