Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

↩️ Revert ORPO loss changes #2527

Merged
merged 4 commits into from
Jan 8, 2025
Merged

↩️ Revert ORPO loss changes #2527

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a830b9
revert orpo changes
kashif Dec 28, 2024
1e1eaaa
Merge branch 'main' into orpo-revert
kashif Jan 6, 2025
753ecf9
Merge branch 'main' into orpo-revert
kashif Jan 8, 2025
8e7648b
add comment
kashif Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions trl/trainer/orpo_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,12 +778,18 @@ def cross_entropy_loss(logits, labels):
loss = loss_fct(logits, labels)
return loss

labels = concatenated_batch["concatenated_labels"].clone()
if self.is_encoder_decoder:
labels = concatenated_batch["concatenated_labels"].clone()
else:
labels = concatenated_batch["concatenated_input_ids"].clone()
attention_mask = concatenated_batch["concatenated_attention_mask"]
labels = torch.where(attention_mask == 1, labels, self.label_pad_token_id)
# orpo chosen nll loss is computed over the full prompt and response
chosen_nll_loss = cross_entropy_loss(all_logits[:len_chosen], labels[:len_chosen])

all_logps = self.get_batch_logps(
all_logits,
labels,
concatenated_batch["concatenated_labels"],
average_log_prob=True,
is_encoder_decoder=self.is_encoder_decoder,
label_pad_token_id=self.label_pad_token_id,
Expand Down
Loading