Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging for PPO + Docs page #243

Merged
merged 7 commits into from
Mar 24, 2023
Merged

Improve logging for PPO + Docs page #243

merged 7 commits into from
Mar 24, 2023

Conversation

natolambert
Copy link
Contributor

I wanted to make it clearer in experiments the difference between the reward model score and the KL penalty. Added PR to do that :).

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 22, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this!
THe proposed changes should fix the failing tests

@natolambert
Copy link
Contributor Author

Ah @younesbelkada the suggestion overwrote a needed variable. I'll fix it today, shouldn't be so bad :)

@natolambert
Copy link
Contributor Author

feel free to merge when ready / happy @younesbelkada @lvwerra

Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @natolambert!

@lvwerra lvwerra merged commit 404621f into main Mar 24, 2023
@lvwerra lvwerra deleted the ppo_logging branch March 24, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants