-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging for PPO + Docs page #243
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this!
THe proposed changes should fix the failing tests
Ah @younesbelkada the suggestion overwrote a needed variable. I'll fix it today, shouldn't be so bad :) |
914c839
to
e59dc57
Compare
feel free to merge when ready / happy @younesbelkada @lvwerra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @natolambert!
I wanted to make it clearer in experiments the difference between the reward model score and the KL penalty. Added PR to do that :).