-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grad accumulation and memory bugfix #220
Conversation
I forgot to run style / quality. I am not on my dev machine at the moment. I will run this in an hour. |
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @edbeeching, looks very clean to me. Just one small comment.
examples/sentiment/scripts/gpt-neox-20b_peft/gpt-neo-20b_sentiment_peft.py
Outdated
Show resolved
Hide resolved
7a19275
to
89c02aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this!
I left a single comment, otherwise the fix proposed in #216 will fail I belive
Co-authored-by: Younes Belkada <[email protected]>
By the way, I think there may be other places we use excessive memory due to storing attached tensors for too long. I will investigate further.