Remove RichProgressCallback
from examples
#2053
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the
RichProgressCallback
from the example scripts because it (a) leads to very messy logs in distributed training, (b) produces hard-to-trace bugs like those encountered in #2043 and (c) introduces a lot of unnecessary branching logic to our scripts just for aesthetic purposes. It has also led to headaches in other libs likeaccelerate
as noted in the issues below:See also this internal thread where
rich
interfered with cloud training: https://huggingface.slack.com/archives/C04EX6W3QSY/p1720008806136549Questions
TRL_USE_RICH=False
by default?Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.