Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SFTTrainer.evaluate() and SFTTrainer.predict() with null train_dataset #2004

Merged
merged 7 commits into from
Sep 13, 2024

Conversation

Sohaib9920
Copy link
Contributor

@Sohaib9920 Sohaib9920 commented Sep 1, 2024

What does this PR do?

Allow using SFTTrainer for only evaluation/prediction when train_dataset is None.

Resolves the exception and passes the sft_trainer test.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for extending the SFTTrainer to support evaluation-only @Sohaib9920! LGTM

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@lewtun lewtun merged commit d832492 into huggingface:main Sep 13, 2024
9 checks passed
@Sohaib9920 Sohaib9920 deleted the fix-sfttrainer-null-dataset branch September 13, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants