-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support loss function for Self-play Preference Optimization #1612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this great addition !
Can you add a section here in the docs to mention this method: https://github.com/huggingface/trl/blob/main/docs/source/dpo_trainer.mdx#loss-functions ! 🙏
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@younesbelkada docs updated. thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot !
cc @kashif wdyt? 🙏 |
Co-authored-by: Kashif Rasul <[email protected]>
@winglian do you want to add an option to the test? e.g. a |
@winglian Thanks for adding our work! @younesbelkada @kashif Just submitted a new pull request at #1615. This updates the loss function according to Equation (4.8), with ![]() It should work well now for the first iteration. Our reported 3 iterations results was based on the soft label version. |
I just gave it a try and it's working better than orpo for me now. |
arxiv: https://arxiv.org/abs/2405.00675