Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lvwerra here is a proposal for HT Transformers update to 4.3.2. The only important compatibility breaking issue I found was related to a parameter name change in
GPT2Model#forward
function. I also upgraded simpletransformers to a version that uses Transformers 4.3.2 as well. I have tried all notebooks in nbs directory to make sure everything works as it used to. I did not upgrade any other libs as I am not that familiar with nbdev environment.04-gpt2-sentiment-ppo-training.ipynb
works as expected and trains in about 2 hours. However, for05-gpt2-sentiment-control.ipynb
I had to lower the batch size to 128 andforward_batch_size
to 4 in order to make the training work and avoid CUDA out of memory errors. The estimated running time on tqdm is 5 hours.