Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add warning when ignored params are passed + parse config file if config if passed #1565

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

younesbelkada
Copy link
Contributor

Fixes #1564

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@younesbelkada younesbelkada marked this pull request as ready for review April 20, 2024 09:23
@younesbelkada younesbelkada changed the title CLI: Add warning when ignored params are passed CLI: Add warning when ignored params are passed + parse config file if config if passed Apr 20, 2024
@younesbelkada
Copy link
Contributor Author

cc @philschmid

@younesbelkada younesbelkada merged commit 113aaae into main Apr 22, 2024
9 checks passed
@younesbelkada younesbelkada deleted the fix-trl-critial branch April 22, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TrlParser not respecting config
3 participants