Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on the
main
branch oftrl
training inbfloat16
& logging withwandb
fails. Users will encounter an error that are hard to interpret.The fixes are the following:
wandb.watch(model)
as it takes care of logging gradients that are in bf16, otherwise users will get an error that is similar to [CLI]: RuntimeError: "histogram_cpu" not implemented for 'BFloat16' wandb/wandb#3332 | I propose to remove this is not a core feature and is a main blocking pointlm_logits
in fp32cc @lvwerra