Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix add_special_tokens issue for data with template #1509

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix add_special_tokens issue for data with template #1509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions trl/trainer/sft_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,12 @@ def make_inputs_require_grad(module, input, output):
# check if dataset has ChatML format or instruction format and is supported
# if not stays #None
formatting_func = get_formatting_func_from_dataset(train_dataset, tokenizer)
# if a template is detected, we don't need to add special tokens again
if formatting_func is not None:
if dataset_kwargs is None:
dataset_kwargs = {"add_special_tokens": False}
else:
dataset_kwargs["add_special_tokens"] = False

if not packing:
if dataset_text_field is None and formatting_func is None:
Expand Down
Loading