Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RichProgressCallback #1496

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Fix RichProgressCallback #1496

merged 2 commits into from
Apr 4, 2024

Conversation

eggry
Copy link
Contributor

@eggry eggry commented Mar 31, 2024

Fix #1495 by modifying the RichProgressCallback.

  • Corrected evaluation & prediction bebaviours,
  • Handle object creation and release more cautious,
  • Corrected the total steps of the evaluation progress bar.

younesbelkada
younesbelkada reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @eggry for the prompt fix!
Can you run the styling checks? make precommit, we'll be able to merge after that

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@eggry
Copy link
Contributor Author

eggry commented Apr 4, 2024

@younesbelkada Thanks for your review. I have updated the styling.

@eggry eggry requested a review from younesbelkada April 4, 2024 17:45
younesbelkada
younesbelkada approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@younesbelkada younesbelkada merged commit 9a28b3f into huggingface:main Apr 4, 2024
9 checks passed
kashif pushed a commit to kashif/trl that referenced this pull request Apr 8, 2024
@eggry @kashif
Fix RichProgressCallback (huggingface#1496)
4d1f4c6 
* fix RichProgressCallback

* Refine code styling in RichProgressCallback tests
kashif pushed a commit to kashif/trl that referenced this pull request Apr 8, 2024
@eggry @kashif
Fix RichProgressCallback (huggingface#1496)
1d3a82d 
* fix RichProgressCallback

* Refine code styling in RichProgressCallback tests
lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
@eggry
Fix RichProgressCallback (huggingface#1496)
d2e08db 
* fix RichProgressCallback

* Refine code styling in RichProgressCallback tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesbelkada younesbelkada younesbelkada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RichProgressCallback would break model evaluation and prediction
3 participants
@eggry @HuggingFaceDocBuilderDev @younesbelkada