Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[peft] Update test_reward_trainer.py to fix tests #1471

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Conversation

kashif
Copy link
Collaborator

@kashif kashif commented Mar 22, 2024

Since we are requiring peft >= 0.4.0

This check fails when peft_version = "0.10.0"

Since we are requiring peft >= 0.4.0
@kashif kashif requested a review from lewtun March 22, 2024 15:40
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@kashif kashif requested a review from vwxyzjn March 22, 2024 18:08
Copy link
Contributor

@vwxyzjn vwxyzjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kashif!

@kashif kashif merged commit d10f766 into main Mar 22, 2024
9 checks passed
@kashif kashif deleted the kashif-patch-1 branch March 22, 2024 18:12
lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
* [peft] Update test_reward_trainer.py

Since we are requiring peft >= 0.4.0

* formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants