[KTO] model init when args are given #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewtun
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
LGTM! Let's see what @younesbelkada thinks about the failing doc build test before merging
|
Let's rebase after #1415 is merged and then merge this once one of the core maintainers approves |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
kashif
added a commit
to fe1ixxu/trl
that referenced
this pull request
Mar 15, 2024
Co-authored-by: Lewis Tunstall <[email protected]>
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
Co-authored-by: Lewis Tunstall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix model init when args are given