Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix padding in dpo trainer #1284

Merged
merged 1 commit into from
Jan 30, 2024
Merged

fix padding in dpo trainer #1284

merged 1 commit into from
Jan 30, 2024

Conversation

pacman100
Copy link
Contributor

What does this PR do?

  1. The padding token in DPO trainer is wrongly set to 0 when tokenizer uses a different token id for padding and tokenizer is passed. This happens because the conditional statement is checking if padding value is None but if the default is 0, it is never None.

@pacman100
Copy link
Contributor Author

cc @younesbelkada

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, in principle this looks good - I would love though a second look from @kashif - let me know what do you think and once that's good for you, feel free to merge!

@younesbelkada younesbelkada requested a review from kashif January 30, 2024 01:59
@kashif
Copy link
Collaborator

kashif commented Jan 30, 2024

great catch thanks!

@kashif kashif merged commit 9186710 into huggingface:main Jan 30, 2024
6 of 9 checks passed
lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants