[xxxTrainer] Add unsloth tag
#1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
danielhanchen
approved these changes
Dec 22, 2023
|
@younesbelkada LGTM! |
younesbelkada
changed the title
SFTTrainer] Add unsloth tagxxxTrainer] Add unsloth tag
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
* add unsloth tag * add it on all trainers * few changes * add in docs * revert * final commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the tag "trl-unsloth" when users use unsloth library: https://github.com/unslothai/unsloth that can bring very interesting out of the box speedups to users.
cc @danielhanchen @lvwerra @osanseviero
@danielhanchen let me know if this looks good to you! Feel free to add any suggestion directly in the PR
Related: unslothai/unsloth#34