peft_module_casting_to_bf16 util method, append_concat_token flag, remove callback PeftSavingCallback
#1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @lvwerra and @younesbelkada |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
pacman100
changed the title
peft_module_casting_to_bf16 util method and append_concat_token flagpeft_module_casting_to_bf16 util method, append_concat_token flag, remove callback PeftSavingCallback
younesbelkada
approved these changes
Dec 19, 2023
lvwerra
approved these changes
Dec 19, 2023
Closed
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
…, remove callback `PeftSavingCallback` (huggingface#1110) * SFT Trainer enhancements * remove the callback `PeftSavingCallback` * bump the version of transformers to `4.31.0` * remove `PeftSavingCallback` from all places.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
peft_module_casting_to_bf16.append_concat_tokenflag so that datasets which already haveeos_tokenat the end of each sample can skip appending the eos/concat tokenPeftSavingCallbackand bumps the minimum transformers version to4.31.0which handles this by default. The currentPeftSavingCallbackwould fail when using PEFT+DeepSpeed and the trainer handles this properly.