Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add datasets as a dependancy #110

Merged
merged 1 commit into from
Jan 25, 2023
Merged

add datasets as a dependancy #110

merged 1 commit into from
Jan 25, 2023

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented Jan 25, 2023

We use datasets in the PPOTrainer so we should add it as a core dependency.

@lvwerra
add datasets as a dependancy
2fcd744 
We use `datasets` in the `PPOTrainer` so we should add it as a core dependency.
@lvwerra lvwerra requested a review from younesbelkada January 25, 2023 13:10
younesbelkada
younesbelkada approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing 🚀 !

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 25, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@lvwerra lvwerra merged commit 607c411 into main Jan 25, 2023
@lvwerra lvwerra deleted the lvwerra-patch-2 branch January 25, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesbelkada younesbelkada younesbelkada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lvwerra @HuggingFaceDocBuilderDev @younesbelkada