Add type hints to core.py #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zachschillaci27, thanks for helping cleanup. Indeed those functions are not used anymore and can be removed! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Got it, done! |
lvwerra
approved these changes
Dec 21, 2023
|
Could you run |
younesbelkada
approved these changes
Dec 22, 2023
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
* Add type hinting to core.py functions * Fixes * Remove unused functions * Remove unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
Just a quick PR to add type hinting to
core.pyI noticed a few methods are not currently used in the codebase, such as
build_bert_batch_from_txtandlistify_batch. Not sure if they are being used elsewhere or we should clean them up. Let me know!Zach