Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restructure examples #107

Merged
merged 1 commit into from
Jan 25, 2023
Merged

restructure examples #107

merged 1 commit into from
Jan 25, 2023

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented Jan 25, 2023

This PR restructures the examples a bit and e.g. removes the full example from the docs as it gets a bit hard to maintain.

@lvwerra lvwerra requested a review from younesbelkada January 25, 2023 10:42
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 25, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

younesbelkada
younesbelkada approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks a lot for refactoring

@lvwerra lvwerra merged commit c1b328e into main Jan 25, 2023
@lvwerra lvwerra deleted the restructure-examples branch January 25, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesbelkada younesbelkada younesbelkada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lvwerra @HuggingFaceDocBuilderDev @younesbelkada