Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix model templates #9999

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Fix model templates #9999

merged 1 commit into from
Feb 4, 2021

Conversation

LysandreJik
Copy link
Member

Some things were forgotten in the model templates after merging #9128

@LysandreJik
Copy link
Member Author

The failing model templates test is untrue. The second model template test (that succeeds) is true. I'll fix the github-actions YAML in a second PR.

patrickvonplaten
patrickvonplaten approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for cleaning up after me! Sorry to have forgotten this in the previous PR

@LysandreJik LysandreJik merged commit e89c959 into master Feb 4, 2021
@LysandreJik LysandreJik deleted the fix-model-templates branch February 4, 2021 12:47
@LysandreJik
Copy link
Member Author

No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LysandreJik @patrickvonplaten