Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GroupedLinearLayer in TF ConvBERT #9972

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Fix GroupedLinearLayer in TF ConvBERT #9972

merged 1 commit into from
Feb 3, 2021

Conversation

abhishekkrthakur
Copy link
Contributor

Fixing an issue with call function in GroupedLinearLayer of ConvBERT

jplu
jplu approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@jplu jplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks for fixing this!

@LysandreJik LysandreJik merged commit a1a67a3 into master Feb 3, 2021
@LysandreJik LysandreJik deleted the gl_fix branch February 3, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplu jplu jplu approved these changes

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhishekkrthakur @jplu @LysandreJik