When on sagemaker use their env variables for saves #9876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LysandreJik
approved these changes
Jan 29, 2021
Comment on lines
+1369
to
+1370
| # If on sagemaker and we are saving the main model (not a checkpoint so output_dir=None), save a copy to | ||
| # SM_MODEL_DIR for easy deployment. |
| "`output_dir` is only optional if it can get inferred from the environment. Please set a value for " | ||
| "`output_dir`." | ||
| ) | ||
| elif os.getenv("SM_OUTPUT_DATA_DIR") is not None: |
There was a problem hiding this comment.
Shouldn't this check is self.output_dir is not None before logging a warning that it's being overwritten?
There was a problem hiding this comment.
Ah yes, good point!
Qbiwan
pushed a commit
to Qbiwan/transformers
that referenced
this pull request
Jan 31, 2021
* When on sagemaker use their env variables for saves * Address review comments * Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When on SageMaker, the content of the env variable "SM_OUTPUT_DATA_DIR" should be used to save training artifacts (such as our checkpoint) so make it overwrite the
output_dir(and make that argument optional so it doesn't need to be passed for sagemaker training).Then the final model will be easy to deploy if it's also saved to the content of the env variable "SM_MODEL_DIR" so adding that as well.