Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup logging with a stdout handler #9816

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Setup logging with a stdout handler #9816

merged 1 commit into from
Jan 27, 2021

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Jan 26, 2021

What does this PR do?

Explicitly add stdout as a handler for the logging configuration in the example scripts, otherwise no logs are reported when training on sagemaker. Also consistently sets the level of the logging outside of the config method, as otherwise it does not work (probably a bug in the logging module).

@sgugger sgugger requested a review from LysandreJik January 26, 2021 20:24
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for taking care of it! LGTM.

@LysandreJik LysandreJik merged commit f2fabed into master Jan 27, 2021
@LysandreJik LysandreJik deleted the scripts_logging branch January 27, 2021 08:39
Qbiwan pushed a commit to Qbiwan/transformers that referenced this pull request Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants