Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for TF mixed precision #9806

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

jplu
Copy link
Contributor

@jplu jplu commented Jan 26, 2021

What does this PR do?

This PR adds a test to check if our TF models are float16 compliant or not. It also helps me to detect what are those that have to be fixed.

@jplu
Copy link
Contributor Author

jplu commented Jan 26, 2021

I don't think that the tests that fails are related to this PR.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! That's a good thing to tackle as we really want all our TF models to work in mixed precision!

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice objective!

@@ -340,14 +340,25 @@ def test_for_multiple_choice(self):

@slow
def test_saved_model_with_attentions_output(self):
# longformer has special attentions which are not
# compatible in graph mode
# This test don't pass because of the error:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we re-run the ci tests to make that they are unrelated? There seemed to be related to network issues

@jplu jplu force-pushed the tf-test-mixed-prec branch from e643cb0 to c149b35 Compare January 26, 2021 17:26
@LysandreJik LysandreJik merged commit 2c891c1 into huggingface:master Jan 27, 2021
@jplu jplu deleted the tf-test-mixed-prec branch January 27, 2021 08:38
Qbiwan pushed a commit to Qbiwan/transformers that referenced this pull request Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants