Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DPRReaderTokenizer's attention_mask #9663

Merged
merged 3 commits into from
Jan 19, 2021

Conversation

mkserge
Copy link
Contributor

@mkserge mkserge commented Jan 18, 2021

What does this PR do?

This PR fixes an issue with the attention_mask not being properly generated by the DPRReaderTokenizer. Please see issue #9555 for more details.

I added an integration test that checks the DPRReader following a similar example in the test file.

I have some test failures due to

"AttributeError: Can't pickle local object 'measure_peak_memory_cpu.<locals>.MemoryMeasureProcess'"

and

"AttributeError: module 'wandb' has no attribute 'ensure_configured'"

which seem to be unrelated to my code changes.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@LysandreJik and @lhoestq would probably be best positioned to review.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you :)

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mkserge!

@LysandreJik LysandreJik merged commit 917dbb1 into huggingface:master Jan 19, 2021
@mkserge mkserge deleted the fix-dpr-attention-mask branch January 19, 2021 15:07
@mkserge
Copy link
Contributor Author

mkserge commented Jan 19, 2021

Thank you both. Should I close the corresponding issue?

@LysandreJik
Copy link
Member

Just did! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants