Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated extras["retrieval"] #9621

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Conversation

n1t0
Copy link
Member

@n1t0 n1t0 commented Jan 15, 2021

The extras["retrieval"] is defined a few lines above as:

transformers/setup.py

Lines 217 to 222 in 28b2601

if os.name == "nt": # windows
extras["retrieval"] = deps_list("datasets") # faiss is not supported on windows
extras["flax"] = [] # jax is not supported on windows
else:
extras["retrieval"] = deps_list("faiss-cpu", "datasets")
extras["flax"] = deps_list("jax", "jaxlib", "flax")

and then it seems to be overridden just below, probably linking to faiss-cpu being included even on windows.

This PR removes the second assignment.

cc @LysandreJik @sgugger @stas00

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @n1t0!

@LysandreJik LysandreJik merged commit 72fc9ab into master Jan 18, 2021
@LysandreJik LysandreJik deleted the fix-retrieval-deps branch January 18, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants