Improve documentation coverage for Phobert #9427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update my fork with lastest
|
Can't pin you for review @sgugger, so tagging you! |
sgugger
approved these changes
Jan 6, 2021
docs/source/model_doc/phobert.rst
Outdated
Comment on lines
39
to
43
| # For transformers v4.x+: | ||
| tokenizer = AutoTokenizer.from_pretrained("vinai/phobert-base", use_fast=False) | ||
|
|
||
| # For transformers v3.x: | ||
| # tokenizer = AutoTokenizer.from_pretrained("vinai/phobert-base") |
There was a problem hiding this comment.
There is no need to differentiate the code. In v4+, when a fast tokenizer is not available, the library will use the slow one. So just tokenizer = AutoTokenizer.from_pretrained("vinai/phobert-base") is good enough!
There was a problem hiding this comment.
reduced to a single line tokenizer = AutoTokenizer.from_pretrained("vinai/phobert-base")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #9035
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.