Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPNet] Add slow to fast tokenizer converter #9233

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Dec 21, 2020

What does this PR do?

Fixes #9194

This PR adds a converter from slow to fast MPNetTokenizers. This way fast tokenizers can be correctly serialized and loaded again. To prevent future issues like #9194, we should maybe think about not allowing to add a "FastTokenizer" without a corresponding converter...what do you think @sgugger, @LysandreJik, @thomwolf ?

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should not allow a fast tokenizer to be merged without the converter to avoid bugs I believe. I can write a script that checks that in the CI ;-)

Edit: Though thinking more about it, there is no need for a script, just a test we can save/reload a custom tokenizer, no?

@patrickvonplaten patrickvonplaten merged commit 9a12b96 into huggingface:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants