Fix slow tests v2 #8746
Merged
Fix slow tests v2 #8746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgugger
reviewed
Nov 23, 2020
tests/test_modeling_bart.py
Outdated
| @@ -492,7 +492,9 @@ def test_mnli_inference(self): | |||
| inputs_dict = prepare_bart_inputs_dict(model.config, input_ids) | |||
| # Test that model hasn't changed | |||
| with torch.no_grad(): | |||
| batched_logits, features = model(**inputs_dict) | |||
| outputs = model(**inputs_dict)[:] | |||
There was a problem hiding this comment.
Suggested change
| outputs = model(**inputs_dict)[:] | |
| outputs = model(**inputs_dict).to_tuple() |
Might be easier toread like this?
There was a problem hiding this comment.
Actually the [:] part wasn't supposed to be part of this PR. The [0] and [1] right below should be enough.
LysandreJik
commented
Nov 24, 2020
LysandreJik
added a commit
that referenced
this pull request
Nov 24, 2020
* Fix BART test * Fix MBART tests * Remove erroneous line from yaml * Update tests/test_modeling_bart.py * Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few tests that were broken in recent PRs.