Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for modifying Processor Kwargs in modular #34477

Conversation

yonigozlan
Copy link
Member

@yonigozlan yonigozlan commented Oct 29, 2024

What does this PR do?

Add support for modifying ProcessingKwargs, ImagesKwargs and TextKwargs in modular. It is currently needed for ColPali, and I think it's nice to have in general, as it could be useful for other multimodal models in the future. Added modular_new_kwargs_model.py to illustrate the need.

Also:

  • Changed an error to a warning when an overwritten function isn't explicitly used in modular. This was making examples that used to work crash, and it seems a bit unnecessarily harsh 😅.
  • Modified a bit the handling of relative imports to avoid false positives (not add "models" automatically if not present).
  • Fixes a problem introduced in a previous PR, not sure which one, where a call to super() would be kept after copying the parent function, when it should be removed.

On that last point, I also added the modular examples to the default call of check_modular_conversion, as otherwise, the modular examples aren't automatically updated when changes are made to modular_model_converter, which makes it hard to trace when issues are introduced. It does make the recurrent checks such as fix-copies heavier though, so not sure if there's a better way to do this.

Who can review?

@ArthurZucker

@yonigozlan yonigozlan marked this pull request as draft October 29, 2024 03:22
@yonigozlan yonigozlan marked this pull request as ready for review October 29, 2024 03:32
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey hey! Sorry, as you saw, @Cyrilvallez is refactoring the modular, this should now be fixed!

@yonigozlan yonigozlan closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants