Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Trainer tokenizer kwarg deprecation with decorator #33887

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

qubvel
Copy link
Member

@qubvel qubvel commented Oct 2, 2024

What does this PR do?

Handle Trainer tokenizer kwarg deprecation with decorator instead of manual deprecation

Follow-up PR for

Who can review?

@amyeroberts

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - a lot cleaner - thanks!

@qubvel qubvel merged commit 2f25ab9 into huggingface:main Oct 2, 2024
22 checks passed
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
…ace#33887)

* Handle deprecation with decorator

* Fix for seq2seq Trainer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants