Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trainer] Undo #29896 #30129

Merged
merged 4 commits into from
Apr 9, 2024
Merged

[Trainer] Undo #29896 #30129

merged 4 commits into from
Apr 9, 2024

Conversation

NielsRogge
Copy link
Contributor

What does this PR do?

This PR reverts #29896 as a better way to handle it is #30102, but that one requires a huge amount of code updates + more extensive offline discussion as it's quite a big change to something people use a lot.

Therefore, a better fix for #29790 is simply this:

default_collator = (
            DataCollatorWithPadding(tokenizer)
            if tokenizer is not None and isinstance(tokenizer, PreTrainedTokenizerBase)
            else default_data_collator
        )

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a comment on separating out the revert and additional change

@NielsRogge
Copy link
Contributor Author

Ok opened a separate PR for this

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this!

@NielsRogge NielsRogge merged commit e9c23fa into huggingface:main Apr 9, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants