-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Trainer] Undo #29896 #30129
[Trainer] Undo #29896 #30129
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just a comment on separating out the revert and additional change
Ok opened a separate PR for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling this!
What does this PR do?
This PR reverts #29896 as a better way to handle it is #30102, but that one requires a huge amount of code updates + more extensive offline discussion as it's quite a big change to something people use a lot.
Therefore, a better fix for #29790 is simply this: