Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gpt-neo-x] Fix gpt neo-x multi gpu training #22089

Closed

Conversation

younesbelkada
Copy link
Contributor

@younesbelkada younesbelkada commented Mar 10, 2023

What does this PR do?

This PR attempts to solve some issues users may encounter when training gpt-neo-x in multiple GPUs

Related: huggingface/trl#210

This PR might be not needed so putting it as draft for now

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 10, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit worried about this as it is too magical. It's up to the users to put all their inputs on the same device. We don't change the device of the labels in all other modeling files.

@younesbelkada
Copy link
Contributor Author

Yes that also what I have thought after opening the PR, I'll find a workaroud to set everything on the correct device

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants