Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete duplicated code #183

Merged
merged 1 commit into from
Nov 23, 2022
Merged

delete duplicated code #183

merged 1 commit into from
Nov 23, 2022

Conversation

Yongtae723
Copy link
Contributor

Hi

I read almost all the code of setfit and found a few mistakes. so I send several PRs for each mistake.

First, there are duplicate codes.
Since batch_size is already defined in two lines above, I think this is no longer necessary.

tomaarsen
tomaarsen approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@tomaarsen tomaarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lewtun
lewtun approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks for the fix!

@lewtun lewtun merged commit b66760c into huggingface:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewtun lewtun lewtun approved these changes

@tomaarsen tomaarsen tomaarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yongtae723 @lewtun @tomaarsen