fix win #924
Closed
fix win #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
nikita-savelyevv
approved these changes
Oct 4, 2024
Comment on lines
+741
to
+747
| def __del__(self): | ||
| if hasattr(self, "request"): | ||
| del self.request | ||
| if hasattr(self, "model"): | ||
| del self.model |
There was a problem hiding this comment.
Is this required or just to be safe?
There was a problem hiding this comment.
I added for experiment to check that process exit issues will be resolved if we remove model and request in destructor. checking that attribute exists added for safety (if somebody already remove them before)
Comment on lines
407
to
419
| def __del__(self): | ||
| if hasattr(self, "request"): | ||
| del self.request | ||
| if hasattr(self, "_original_model"): | ||
| del self._original_model | ||
| if hasattr(self, "model"): | ||
| del self.model |
|
I still getting segmentation fault (probably caused double free memory corruption in my experiments with resolving tmp dir destruction, so I moved changes required for compression into separated PR to unblock people that waiting this issue resolution #925 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # openvinotoolkit/openvino#26844
force deleting openvino model and garbage collector during model export to prevent locking files in tmp dir due to mmap.
Additionally fixed installation from source on windows (in setup.py, subprocess.run raises FileNotFound error if can not find git) and refactoring weights compression part moving model size calculation during export and read model only if weights compression should be applied (based on model size or explicitly specified configuration, prevents OOM and invalid IR errors if nncf not installed)
Before submitting