Limit position embeddings in inference #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom (huggingface#57) model code. Co-authored-by: Adam Stachowicz <[email protected]>
bhargaveede
requested review from
mandy-li,
libinta and
regisss
as code owners
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
regisss
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
LGTM.
@bhargaveede Can you also address the unsolved comments in #1501 please? At least moving parallel_state.py to optimum/habana/distributed. Using more recent versions of Llama for CI can be done after release, but moving parallel_state.py should be done before release. Otherwise that will be a breaking change in the release after and we should avoid that. It's just about moving one file and updating a couple of imports.
regisss
pushed a commit
that referenced
this pull request
Dec 12, 2024
Co-authored-by: Adam Stachowicz <[email protected]>
zzhang37
pushed a commit
to zzhang37/optimum-habana
that referenced
this pull request
Dec 12, 2024
Co-authored-by: Adam Stachowicz <[email protected]>
Liangyx2
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jan 20, 2025
Co-authored-by: Adam Stachowicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the max_position_embeddings truncation from model code as it hampers with training.
Moved it to text-generation/utils.py as that's better place
Fixes # (issue)
Before submitting