Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes the with_stack of the profiler changeable #1497

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Makes the with_stack of the profiler changeable #1497

merged 2 commits into from
Nov 27, 2024

Conversation

ranzhejiang
Copy link
Contributor

@ranzhejiang ranzhejiang commented Nov 18, 2024 •
edited
Loading

The default argument of profiler with_stack is False. Enabling this can help performance analysis align with model function，through it need more memory usage, we still need it to locate problem code.
This pr makes the with_stack changeable (for customer demands).

@ranzhejiang ranzhejiang requested a review from regisss as a code owner November 18, 2024 07:08
@github-actions GitHub Actions
Copy link

The code quality check failed, please run make style.

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ranzhejiang
Copy link
Contributor Author

I have done the make style

@jiminha jiminha added the run-test Run CI for PRs from external contributors label Nov 25, 2024
@github-actions GitHub Actions
Copy link

The code quality check failed, please run make style.

@regisss
Copy link
Collaborator

regisss commented Nov 26, 2024

@ranzhejiang Can you make sure your branch is synced with main and run make style again please?

@ranzhejiang
Copy link
Contributor Author

ranzhejiang commented Nov 26, 2024 •
edited
Loading

@ranzhejiang Can you make sure your branch is synced with main and run make style again please?

I have checked it again and find the error is not related with my pr, I will rebase PR anyway

@regisss
Copy link
Collaborator

regisss commented Nov 26, 2024

@ranzhejiang Can you make sure your branch is synced with main and run make style again please?

I have checked it again and find the error is not related with my pr, I will rebase PR anyway

Yes, it's not related to your PR. Syncing with main will solve it.

@ranzhejiang
Copy link
Contributor Author

@ranzhejiang Can you make sure your branch is synced with main and run make style again please?

I have checked it again and find the error is not related with my pr, I will rebase PR anyway

Yes, it's not related to your PR. Syncing with main will solve it.

Done with syncing with main branch

@regisss regisss merged commit 1904851 into huggingface:main Nov 27, 2024
3 of 4 checks passed
Liangyx2 pushed a commit to HabanaAI/optimum-habana-fork that referenced this pull request Jan 20, 2025
@ranzhejiang @Liangyx2
Makes the with_stack of the profiler changeable (huggingface#1497)
7cc2650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiminha jiminha jiminha approved these changes

@regisss regisss regisss approved these changes

Assignees
No one assigned
Labels
run-test Run CI for PRs from external contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ranzhejiang @HuggingFaceDocBuilderDev @regisss @jiminha